Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Initialize rcd_2023_03_17 data #112

Merged
merged 7 commits into from
Mar 22, 2023
Merged

Initialize rcd_2023_03_17 data #112

merged 7 commits into from
Mar 22, 2023

Conversation

edelarua
Copy link
Contributor

Closes #109

@edelarua edelarua added the sme label Mar 21, 2023
@edelarua
Copy link
Contributor Author

edelarua commented Mar 21, 2023

@Melkiades any idea why it would require lubridate for loading cached data (only when --as-cran)? https://github.com/insightsengineering/scda.2022/actions/runs/4483374122/jobs/7882588517?pr=112#step:35:108

@shajoezhu
Copy link
Contributor

any functions that we need to import from lubridate?

@Melkiades
Copy link
Contributor

@Melkiades any idea why it would require lubridate for loading cached data (only when --as-cran)? https://github.com/insightsengineering/scda.2022/actions/runs/4483374122/jobs/7882588517?pr=112#step:35:108

Could it be because of the metadata where there is the date and datetime class?

@edelarua
Copy link
Contributor Author

edelarua commented Mar 22, 2023

@Melkiades any idea why it would require lubridate for loading cached data (only when --as-cran)? https://github.com/insightsengineering/scda.2022/actions/runs/4483374122/jobs/7882588517?pr=112#step:35:108

Could it be because of the metadata where there is the date and datetime class?

That shouldn't be the case since the date class uses as.Date and the datetime class uses as.POSIXct, both of which convert to base R classes.

EDIT: I found the issue - the study_duration_secs attribute for adsl needs to be converted to numeric.

@edelarua
Copy link
Contributor Author

edelarua commented Mar 22, 2023

Unblocked by insightsengineering/random.cdisc.data#259

@edelarua edelarua removed the blocked label Mar 22, 2023
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I would just add something to NEWS ;)

Well done!

@edelarua edelarua merged commit dba91c9 into main Mar 22, 2023
@edelarua edelarua deleted the 109_new_snapshot@main branch March 22, 2023 18:51
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New snapshot rcd_2023_03_17 after release 0.1.4
3 participants