Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request]: Implement label to the filter-state #130

Closed
Tracked by #6
gogonzo opened this issue Nov 23, 2022 · 6 comments
Closed
Tracked by #6

[Feature Request]: Implement label to the filter-state #130

gogonzo opened this issue Nov 23, 2022 · 6 comments
Labels
Blocked core enhancement New feature or request

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Nov 23, 2022

part of #48 should rather follow #129

Feature description

Label should be a reactiveValue which:

  1. by default it observes private$selected (filter values) and label should be:
    • for numeric, dates and datetime {dataname}.{varname}: {min(selected)}-{max(selected)}
    • for characters and factors {dataname}{varname}: {paste(selected, collapse = ",")}. Length of the label should be limited to X characters. We can figure value of X during the implementation
  2. It should observe also textInput where user can specify the label. After label is applied - it no longer follows reactive selection (1)
  3. Please add protection to not have a duplicated label.

image

@donyunardi
Copy link
Contributor

donyunardi commented Feb 28, 2023

Due to our de#date, I feel that we can close this issue.

In summary, the current state of the filter card includes two rows: the first row displays the column name and label (if applicable), while the second row shows the selected values, which change dynamically based on user input.

@gogonzo thoughts?

@gogonzo
Copy link
Contributor Author

gogonzo commented Mar 1, 2023

I think this is still needed but the result should be discussed. Maybe users should be allowed to set values of the filter, name it accordingly (e.g. "adult") to avoid showing numbers which might not say anything. I'd like to discuss this at some point

@donyunardi
Copy link
Contributor

Thanks, we can discuss this more.
Priority-wise, let's address this at the next increment.

@donyunardi
Copy link
Contributor

Let's start the discussion.

@lcd2yyz
Could you please define the expectation of the filter-state label from user's perspective?

  • How the label should look based on current design?
  • What's the behavior of the label?
  • Should value be shown under the label or should it tooltips, etc?
  • I think filter-state label is motivated by citril/citril.metadata, should we gather user requirement from that team too?

@lcd2yyz
Copy link

lcd2yyz commented Mar 28, 2023

This is closely related to #220 , let's tackle these together in a discussion session.

@donyunardi
Copy link
Contributor

Per discussion with @lcd2yyz, this is no longer needed in favor of filter expression.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Blocked core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants