Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Counts of the filtered state are missleading #166

Closed
Tracked by #165
gogonzo opened this issue Jan 19, 2023 · 0 comments
Closed
Tracked by #165

Counts of the filtered state are missleading #166

gogonzo opened this issue Jan 19, 2023 · 0 comments
Assignees
@gogonzo
Labels
core

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Jan 19, 2023

So the counts I think are not as helpful as they could be - when you deselect "M" you get 0/399:
image

But it's probably more informative to have:
image

So you can see there are 305 available given other filtering out of the 399 in total. And then checking/un-checking the checkbox does not change the label

Similar for keep_na and keep_inf
@gogonzo gogonzo added the core label Jan 19, 2023
This was referenced Jan 19, 2023
Merged
Closed
@gogonzo gogonzo self-assigned this Jan 20, 2023
@gogonzo gogonzo assigned gogonzo and unassigned gogonzo Feb 17, 2023
@gogonzo gogonzo mentioned this issue Feb 22, 2023
Merged
gogonzo added a commit that referenced this issue Mar 3, 2023
@gogonzo
filtered counts excluding $this filter (#205)
03e8b25 
Closes #166 
 implements filtered counts and prepares for the hierarchical filtering
@gogonzo gogonzo closed this as completed Mar 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gogonzo