Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Filterstate initialization reorganized + limited choices #232

Closed
BLAZEWIM opened this issue Mar 17, 2023 · 0 comments
Closed

Filterstate initialization reorganized + limited choices #232

BLAZEWIM opened this issue Mar 17, 2023 · 0 comments
Assignees
@BLAZEWIM
Labels
core

Comments

@BLAZEWIM
Copy link
Contributor

Supporting work for #222

#225
@BLAZEWIM BLAZEWIM added the core label Mar 17, 2023
@BLAZEWIM BLAZEWIM self-assigned this Mar 17, 2023
@BLAZEWIM BLAZEWIM mentioned this issue Mar 17, 2023
Merged
BLAZEWIM added a commit that referenced this issue Mar 22, 2023
@BLAZEWIM @gogonzo @chlebowa
Limited choices@187 new api@filter panel refactor@main (#225)
03178e5 
Should be reviewed together / with regard to
#222

Closes #232

Problems to solve:
- when initializing `FilterState` using FilterPanel API with choices,
when parameter choices limits the number of possible values to select
from, `is_any_filtered` should be set to TRUE to notice that the filter
is applied always, therefore it must appear in the call.
- test could not run due to different errors, mostly `argument
"dataname" missing`
- remove class `InteractiveFilterState` and `FilterState-abstract`, as
they are not needed anymore (fixed filter will be set using `fixed`
parameter)
```
state <- ChoicesFilterState$new(
  letters[c(1, 2)],
  x_reactive = reactive(NULL),
  "test",
  "var",
  choices = c("a", "b"),
  selected = c("a", "b"),
)
shiny::isolate(state$get_state())
state$.__enclos_env__$private$is_choice_limited

state <- ChoicesFilterState$new(
  letters,
  x_reactive = reactive(NULL),
  "test",
  "var",
  choices = c("a", "b"),
  selected = c("a", "b"),
)
shiny::isolate(state$get_state())
state$.__enclos_env__$private$is_choice_limited
```


# Pull Request

Part of #187

---------

Signed-off-by: Marek Blazewicz <110387997+BLAZEWIM@users.noreply.github.com>
Co-authored-by: Blazewicz <blazewim@emea.roche.com>
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@BLAZEWIM BLAZEWIM

Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BLAZEWIM