Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add set filter #724

Merged
merged 10 commits into from
Sep 2, 2022
Merged

add set filter #724

merged 10 commits into from
Sep 2, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Aug 23, 2022

Part of insightsengineering/teal.slice#70 needs insightsengineering/teal.slice#93

FYI @wangh107 @kumamiao

Test with, for example:

library(teal)
library(scda)

ADSL <- synthetic_cdisc_data("latest")$adsl
ADAE <- synthetic_cdisc_data("latest")$adae

app <- init(
  data = cdisc_data(
    cdisc_dataset("ADSL", ADSL, code = "ADSL <- synthetic_cdisc_data(\"latest\")$adsl"),
    cdisc_dataset("ADAE", ADAE, code = "ADAE <- synthetic_cdisc_data(\"latest\")$adae")
  ),
  modules = modules(
    example_module()
  ),
  filter = list(ADSL = structure(list(AGE = list()), "filterable" = c("AGE", "SEX", "RACE")))
)

shinyApp(app$ui, app$server)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      131      51  61.07%   66, 73, 78, 139-148, 186, 212-261
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   174, 185-186, 239-260
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             113      16  85.84%   57, 96, 100-117, 163, 212, 257
R/module_tabs_with_filters.R        68       1  98.53%   159
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      20  83.19%   49, 52, 142-143, 156-162, 168-174, 197, 227
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        115       9  92.17%   218, 423-448
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              973     345  64.54%

Results for commit: da35e45

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022

Unit Tests Summary

    1 files    10 suites   11s ⏱️
107 tests 107 ✔️ 0 💤 0
207 runs  207 ✔️ 0 💤 0

Results for commit 055279d.

♻️ This comment has been updated with latest results.

@Polkas Polkas self-assigned this Aug 23, 2022
Nikolas Burkoff and others added 7 commits August 24, 2022 13:46
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
@Polkas Polkas requested a review from gogonzo August 29, 2022 07:20
Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nikolas Burkoff and others added 2 commits September 2, 2022 13:12
Co-authored-by: Pawel Rucki <pawelrucki@gmail.com>
@nikolas-burkoff nikolas-burkoff enabled auto-merge (squash) September 2, 2022 12:14
@nikolas-burkoff nikolas-burkoff merged commit ac26a19 into main Sep 2, 2022
@nikolas-burkoff nikolas-burkoff deleted the 70_set_filterable@main branch September 2, 2022 12:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants