Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ConfigurationFilesCacheReloadTask prints warning for empty files #857

Closed
JonasKunz opened this issue Jul 20, 2020 · 0 comments · Fixed by #859
Closed

ConfigurationFilesCacheReloadTask prints warning for empty files #857

JonasKunz opened this issue Jul 20, 2020 · 0 comments · Fixed by #859
Assignees
Labels
area/config-server bug Something isn't working

Comments

@JonasKunz
Copy link
Member

When saving an empty File or a File with only whitespaces / comments, the ConfigurationFilesCacheReloadTask will show a warning ConfigurationFilesCacheReloadTask - Unable to load file with path ....

This happens because SnakeYAML returns null in this case, which we interpret as error.
This is wrong, we should only print a warning if SnakeYAML threw an exception.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/config-server bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants