Closes #1136 - Pull changes of a remote Git repository into the local workspace of a Configuration Server #1145
Conversation
mariusoe
force-pushed
the
feature/1136-pull-remote
branch
from
22605c4 to
d445d8b
Compare
There was a problem hiding this comment.
Reviewed 7 of 9 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mariusoe)
components/inspectit-ocelot-configurationserver/src/main/resources/application.yml, line 76 at r2 (raw file):
# configuration synchronization. The initial synchronization is not related to the 'pull-at-startup' property! # Read the documentation for detailed information on this property! initial-configuration-sync: true
Should the value set default to false?
components/inspectit-ocelot-configurationserver/src/test/java/rocks/inspectit/ocelot/file/FileManagerTest.java, line 13 at r2 (raw file):
import rocks.inspectit.ocelot.file.accessor.workingdirectory.CachingWorkingDirectoryAccessor; import java.io.IOException;
why?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Patrick-Eichhorn)
components/inspectit-ocelot-configurationserver/src/main/resources/application.yml, line 76 at r2 (raw file):
Previously, Patrick-Eichhorn wrote…
Should the value set default to false?
Done.
components/inspectit-ocelot-configurationserver/src/test/java/rocks/inspectit/ocelot/file/FileManagerTest.java, line 13 at r2 (raw file):
Previously, Patrick-Eichhorn wrote…
why?
Done.
There was a problem hiding this comment.
Reviewed 6 of 9 files at r1, 1 of 3 files at r2, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Patrick-Eichhorn)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @mariusoe)
closes #1136
This change is