New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Closes #1184 - New Demo setup needed for InfluxDB and Jaeger combination #1186

Merged

Patrick-Eichhorn merged 2 commits into inspectIT:master from timwildberger:iss1184

Aug 16, 2021

Contributor

timwildberger commented Aug 12, 2021 •

edited by mariusoe

Loading

closes #1184

This change is


          updated json for sdg-grafana-panel and added docker compose for influ…

19f21f2

…xdb-jaeger combination

Patrick-Eichhorn changed the title ~~Closes #1184~~ Closes #1184 - New Demo setup needed for InfluxDB and Jaeger combination

Patrick-Eichhorn self-assigned this

timwildberger force-pushed the iss1184 branch from ab1370a to 19f21f2 Compare

August 12, 2021 13:24

Patrick-Eichhorn requested changes

View reviewed changes

Contributor

Patrick-Eichhorn left a comment

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 14 unresolved discussions (waiting on @Patrick-Eichhorn and @timwildberger)

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 7 at r1 (raw file):

:1.11.1

Can you edit the tag, to use the Environment Variable (.env file)?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 15 at r1 (raw file):

:1.11.1

see above

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 29 at r1 (raw file):

1.6

Can you test/add the newest stable release (IMO this is 1.25.0)?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 36 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 43 at r1 (raw file):

      - INSPECTIT_EXPORTERS_METRICS_PROMETHEUS_ENABLED=false
      - INSPECTIT_EXPORTERS_METRICS_INFLUX_URL=http://influxdb:8086
      - INSPECTIT_EXPORTERS_TRACING_JAEGER_URL=http://jaeger:14268/api/traces

Maybe we can add the Exporter Settings to the Configuration Server, this is a good example for agent mapping (for all petclinic services, one config -> Agent Mapping)

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 55 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 75 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 96 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 117 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 138 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 158 at r1 (raw file):

tracing-server:

IMO this service is not required?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 168 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 184 at r1 (raw file):

1.7.1

Can you test/add the newest InfluxDB (1) Release (IMO this is 1.8 )

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 211 at r1 (raw file):

inspectit-oce-demo-1.0

Can you add and use this tag to/from the .env File?


          preliminary version

cb5b436

timwildberger commented

View reviewed changes

Contributor Author

timwildberger left a comment

Reviewable status: 1 of 2 files reviewed, 14 unresolved discussions (waiting on @Patrick-Eichhorn)

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 7 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

:1.11.1
Can you edit the tag, to use the Environment Variable (.env file)?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 15 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

:1.11.1
see above

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 29 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

1.6
Can you test/add the newest stable release (IMO this is 1.25.0)?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 36 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 43 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

Maybe we can add the Exporter Settings to the Configuration Server, this is a good example for agent mapping (for all petclinic services, one config -> Agent Mapping)

We don't need to specify the Exporters since the configuration file gets used for every docker-compose-file with every collector-agent-combination.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 55 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 75 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 96 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 117 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 138 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 158 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

tracing-server:
IMO this service is not required?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 168 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 184 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

1.7.1
Can you test/add the newest InfluxDB (1) Release (IMO this is 1.8 )

Done.

inspectit-ocelot-demo/docker-compose-influxdb-jaeger.yml, line 211 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

inspectit-oce-demo-1.0
Can you add and use this tag to/from the .env File?

Done.

Patrick-Eichhorn approved these changes

View reviewed changes

Contributor

Patrick-Eichhorn left a comment

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @timwildberger)

Patrick-Eichhorn merged commit caa5e45 into inspectIT:master

Patrick-Eichhorn added a commit that referenced this pull request


          Revert "Closes #1184 - New Demo setup needed for InfluxDB and Jaeger …

28c1159

…combination (#1186)"

This reverts commit caa5e45.

timwildberger deleted the iss1184 branch

August 17, 2021 15:35

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet