Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closes #1193 - Update the documentation to include the changes to the demo #1198

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

Mahir-Isikli
Copy link
Member

@Mahir-Isikli Mahir-Isikli commented Aug 20, 2021

closes #1193


This change is Reviewable

Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @Mahir-Isikli and @Patrick-Eichhorn)


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 33 at r2 (raw file):

* File: `docker-compose-influxdb-jaeger.yml`
* [OpenAPM Landscape](https://openapm.io/landscape?agent=inspectit-ocelot-agent&instrumentation-lib=opencensus&collector=jaeger-collector&storage=influx-db&visualization=jaeger-query&dashboarding=grafana&alerting=grafana&showCommercial=false&showFormats=false)

In this link, the Jaeger UI is connected to Grafana, but this connection does not exist.


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 134 at r2 (raw file):

flux

Flux is the query language for influxDB version > 2.0, we still use the 1.x version and therefore the query language InfluxQL. Please also verify this for the influx-zipkin setup


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 178 at r2 (raw file):

- *visits-service*
- *vets-service*
- *api-gateway*

Can you add a chapter Load Test after ## Changing Agent Configurations? (for each demo setup a load test runs, the user behavior is simulated / artillery is used and briefly describe what is called how and how often).

Copy link
Member Author

@Mahir-Isikli Mahir-Isikli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @Patrick-Eichhorn)


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 33 at r2 (raw file):

Previously, Patrick-Eichhorn wrote…

In this link, the Jaeger UI is connected to Grafana, but this connection does not exist.

Done.


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 134 at r2 (raw file):

Previously, Patrick-Eichhorn wrote…
flux

Flux is the query language for influxDB version > 2.0, we still use the 1.x version and therefore the query language InfluxQL. Please also verify this for the influx-zipkin setup

Done.


inspectit-ocelot-documentation/docs/getting-started/docker-examples.md, line 178 at r2 (raw file):

Previously, Patrick-Eichhorn wrote…

Can you add a chapter Load Test after ## Changing Agent Configurations? (for each demo setup a load test runs, the user behavior is simulated / artillery is used and briefly describe what is called how and how often).

Done.

Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Mahir-Isikli)

@Patrick-Eichhorn Patrick-Eichhorn merged commit 0a5c5ae into inspectIT:master Aug 25, 2021
@Mahir-Isikli Mahir-Isikli deleted the iss1193 branch September 6, 2021 11:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the documentation to include the changes to the demo
3 participants