Closes #1354 - fix(config-server/config-server-ui) Support enums in Collections in Highlighting

[aaronweissler]

This change is 

[heiko-holz]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)

---

components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/yamlhighlighter/HighlightRulesMapController.java, line 109 at r1 (raw file):

            } else if (currentClass.equals(GenericActionSettings.class) && (field.getName()
                    .equals("value") || field.getName().equals("valueBody"))) {

do we maybe want to support equalsIgnoreCase in case someone writes valuebody, ValueBody or other forms?

---

components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/yamlhighlighter/HighlightRulesMapController.java, line 139 at r1 (raw file):

    private List<String> extractEnumValues(Class<?> currentEnum) {
        List<String> enumValues = new ArrayList<>();

you could also use the Arrays.stream functions:

List<String> extractedEnums =  Arrays.stream(currentEnum.getFields()).map(field -> field.getName()).collect(Collectors.toList());

Code quote:

extractEnum

[aaronweissler]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)

---

components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/yamlhighlighter/HighlightRulesMapController.java, line 109 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

do we maybe want to support equalsIgnoreCase in case someone writes valuebody, ValueBody or other forms?

The String "valueBody" here comes from the name of the field in the java class GenericActionSettings itself, so it will always be "valueBody", unless someone else refactors that code (which, related but not really your question, as of now would silently break the highlighter, but I don't know if it is worth it to stop that by for example checking that this if clause is reached twice, since it is rather unlikely to be changed?)

---

components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/yamlhighlighter/HighlightRulesMapController.java, line 139 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

you could also use the Arrays.stream functions:

List<String> extractedEnums =  Arrays.stream(currentEnum.getFields()).map(field -> field.getName()).collect(Collectors.toList());

That's a good idea, I'll change it :)

[heiko-holz]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)

---

components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/rest/yamlhighlighter/HighlightRulesMapController.java, line 109 at r1 (raw file):

Previously, aaronweissler wrote…

The String "valueBody" here comes from the name of the field in the java class GenericActionSettings itself, so it will always be "valueBody", unless someone else refactors that code (which, related but not really your question, as of now would silently break the highlighter, but I don't know if it is worth it to stop that by for example checking that this if clause is reached twice, since it is rather unlikely to be changed?)

okay, then equals sounds more appropriate