fix(config-ui) - Small grammatical corrections in Scope Wizard #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweissler
commented
Mar 30, 2022
| @@ -68,7 +68,7 @@ const TypeMatcher = ({ typeMatcher, onTypeMatcherChange, onShowClassBrowser }) = | |||
| <div className="row-center"> | |||
| <Dropdown style={{ width: '7rem' }} value={typeMatcher.type} options={types} onChange={(e) => setState('type', e.value)} /> | |||
| <label className="inner-label" htmlFor="which"> | |||
| which name | |||
| name | |||
There was a problem hiding this comment.
I personally preferred simply removing the "which", since it still expresses what it is supposed to just fine and then it is just a bit less somewhat redundant text in the UI. We could also replace it with a "whose" which would then be grammatically correct and analogous to the way it is written in the overview after finishing creating a scope with the scope wizard :)
MariusBrill
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @MariusBrill)
MariusBrill
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is