Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closes #1407 - Insert events into preloaded logs #1411

Merged
merged 4 commits into from
May 10, 2022

Conversation

Henning-Schulz
Copy link
Member

@Henning-Schulz Henning-Schulz commented Apr 29, 2022

Artificially added log events will look like follows.

2022-04-29 10:47:42,709 INFO 33860 --- [inspectIT] [pectit-thread-1] ### LOG-INVALIDATING EVENT ### : Property sources reload! Some previous log messages may now be outdated.


This change is Reviewable

@Henning-Schulz Henning-Schulz marked this pull request as draft April 29, 2022 08:59
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1411 (68dd0f9) into master (3bff0ca) will increase coverage by 0.03%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master    #1411      +/-   ##
============================================
+ Coverage     81.20%   81.23%   +0.03%     
- Complexity     2109     2110       +1     
============================================
  Files           215      215              
  Lines          6691     6706      +15     
  Branches        785      786       +1     
============================================
+ Hits           5433     5447      +14     
  Misses          955      955              
- Partials        303      304       +1     
Impacted Files Coverage Δ
...ectit/ocelot/core/selfmonitoring/LogPreloader.java 80.36% <87.50%> (+2.31%) ⬆️
...nspectit/ocelot/core/utils/HighPrecisionTimer.java 90.62% <0.00%> (+1.56%) ⬆️

@Henning-Schulz
Copy link
Member Author

Now without beginner's mistakes 😄

@Henning-Schulz Henning-Schulz marked this pull request as ready for review April 29, 2022 12:03
Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Henning-Schulz and @MariusBrill)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/selfmonitoring/LogPreloader.java line 65 at r1 (raw file):

        if (invalidator != null) {
            String invalidationString = invalidator.getClass().getSimpleName();
            if (invalidationString.endsWith("Event")) {

I am not quite sure why we need this. Maybe we could have a short call about it?

Copy link
Member Author

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @MariusBrill)


inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/selfmonitoring/LogPreloader.java line 65 at r1 (raw file):

Previously, MariusBrill (Marius Brill) wrote…

I am not quite sure why we need this. Maybe we could have a short call about it?

It is for formatting the log message. I added a comment and changed the code a little to make it better understandable.

Copy link
Member

@MariusBrill MariusBrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Henning-Schulz)

@MariusBrill MariusBrill merged commit 8a59be6 into inspectIT:master May 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants