Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add down propagated data to late BrowserPropagationDataStorage #1621

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

EddeCCC
Copy link
Member

@EddeCCC EddeCCC commented Oct 13, 2023

If a BrowserPropagationDataStorage is not created in the first context, but in a later one, earlier created data, which was down propagated still has to be included into the data storage.


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1621 (8dc01b2) into master (a4e425a) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 8dc01b2 differs from pull request most recent head f2d4a34. Consider uploading reports for the commit f2d4a34 to get more accurate results

@@             Coverage Diff              @@
##             master    #1621      +/-   ##
============================================
+ Coverage     78.32%   78.37%   +0.05%     
- Complexity     2518     2520       +2     
============================================
  Files           257      257              
  Lines          8256     8257       +1     
  Branches        984      984              
============================================
+ Hits           6466     6471       +5     
+ Misses         1364     1358       -6     
- Partials        426      428       +2     
Files Coverage Δ
.../instrumentation/context/InspectitContextImpl.java 91.47% <100.00%> (-0.44%) ⬇️

... and 3 files with indirect coverage changes

@EddeCCC EddeCCC requested a review from TitusLabs October 16, 2023 16:45
Copy link
Contributor

@TitusLabs TitusLabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EddeCCC)

@EddeCCC EddeCCC merged commit aeb572d into master Oct 19, 2023
@EddeCCC EddeCCC deleted the internal-browser-propagation-data-storage branch December 14, 2023 13:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants