Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closes #703 - Visual editor of the configuration UI shows possible values of Enum properties #878

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

MariusBrill
Copy link
Member

@MariusBrill MariusBrill commented Aug 3, 2020

This change is Reviewable

@MariusBrill MariusBrill linked an issue Aug 3, 2020 that may be closed by this pull request
@mariusoe mariusoe changed the title Closes #703 - Added Visual Enum Editor Closes #703 - Visual editor of the configuration UI shows possible values of Enum properties Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #878 (130877d) into master (d37a7dc) will decrease coverage by 0.09%.
The diff coverage is 79.83%.

@@             Coverage Diff              @@
##             master     #878      +/-   ##
============================================
- Coverage     83.00%   82.92%   -0.09%     
- Complexity     1736     1761      +25     
============================================
  Files           174      178       +4     
  Lines          5366     5467     +101     
  Branches        650      656       +6     
============================================
+ Hits           4454     4533      +79     
- Misses          675      690      +15     
- Partials        237      244       +7     
Impacted Files Coverage Δ Complexity Δ
...t/ocelot/config/model/tracing/TracingSettings.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...rocks/inspectit/ocelot/config/utils/CaseUtils.java 90.48% <0.00%> (-4.98%) 8.00 <0.00> (ø)
...lation/log/adapters/JBossLogmanagerMDCAdapter.java 66.67% <66.67%> (ø) 2.00 <2.00> (?)
...nstrumentation/context/ContextPropagationUtil.java 84.73% <70.37%> (-3.00%) 31.00 <3.00> (+5.00) ⬇️
...t/ocelot/config/validation/PropertyPathHelper.java 79.17% <71.43%> (-1.45%) 42.00 <2.00> (-1.00)
...rumentation/context/propagation/DatadogFormat.java 77.14% <77.14%> (ø) 7.00 <7.00> (?)
...trumentation/context/PropagationFormatManager.java 80.00% <80.00%> (ø) 3.00 <3.00> (?)
...ocelot/config/model/tracing/PropagationFormat.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ore/instrumentation/correlation/log/MDCAccess.java 87.80% <100.00%> (+3.93%) 16.00 <3.00> (+3.00)
...ion/correlation/log/adapters/Log4J1MDCAdapter.java 80.00% <100.00%> (+2.22%) 4.00 <1.00> (+1.00)
... and 7 more

@mariusoe mariusoe self-assigned this Aug 7, 2020
@mariusoe mariusoe force-pushed the master branch 8 times, most recently from a46e5e8 to 1b7db27 Compare January 20, 2021 15:28
Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mariusoe mariusoe merged commit 36c6c59 into inspectIT:master Feb 25, 2021
@MariusBrill MariusBrill deleted the Visual_Enum_Editor branch May 25, 2021 10:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enums to the visual properties editor
2 participants