Closes #909 - Extend configuration UI to be able to search in the content of the configuration files

[mariusoe]

This change is 

[fylip97]

Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @mariusoe)

a discussion (no related file):

If you open a file in a subfolder while searching, it might be good to open the subfolder in the filetree to see the marked file.

---

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/ConfigurationView.js, line 118 at r1 (raw file):

  hideSearchDialog = () => this.setState({ isSearchDialogShown: false });

  openFile = (filename) => {

The name openFile could be confusing because the method is only called after the search and not every time a file is opened.
Maybe it should be renamed to openSeachedFile or something similar.

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 78 at r1 (raw file):

              </span>
            ) : (
              match.text

Can you format the file.

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 95 at r1 (raw file):

  /** The line number where the matches are starting */
  lineNumber: PropTypes.number,
  /** The file's content on the current lin */

Isn't lin missing an e?

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 321 at r1 (raw file):

              />
            ) : (
              <span className="no-data">Nothing to show</span>

Please format the line.

[mariusoe]

Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @fylip97)

a discussion (no related file):

Previously, fylip97 (Philip Dengler) wrote…

If you open a file in a subfolder while searching, it might be good to open the subfolder in the filetree to see the marked file.

This is done in a separate ticket

---

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/ConfigurationView.js, line 118 at r1 (raw file):

Previously, fylip97 (Philip Dengler) wrote…

The name openFile could be confusing because the method is only called after the search and not every time a file is opened.
Maybe it should be renamed to openSeachedFile or something similar.

True, this is currently only used by the search dialog, but I would still keep it because acutually every component could use this for opening a file.

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 78 at r1 (raw file):

Previously, fylip97 (Philip Dengler) wrote…

Can you format the file.

Hmm acutally, the formatting should be correct, otherwise the tests should fail as well.

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 95 at r1 (raw file):

Previously, fylip97 (Philip Dengler) wrote…

Isn't lin missing an e?

Done

---

components/inspectit-ocelot-configurationserver-ui/src/components/views/configuration/dialogs/SearchDialog.js, line 321 at r1 (raw file):

he formatting should be correct, otherwise the tests should fail as well.
Here as well - the formatting should be correct, otherwise the tests should fail as well.

[fylip97]

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved