-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix match expression documentation #939
Fix match expression documentation #939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Patrick-Eichhorn)
components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):
{'Options are: level(), changed() and tag matching.'} <br /> {'Example: (level() >= WARNING) AND ("host" == \'s001.example.com\')'}
My feeling says it should be the same quote sign, e.g., "host" == "s001.example.com"
, but I might be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Henning-Schulz)
components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):
Previously, Henning-Schulz (Henning Schulz) wrote…
My feeling says it should be the same quote sign, e.g.,
"host" == "s001.example.com"
, but I might be wrong.
This is due to the Tick Script-, more precisely the InfluxDB -Syntax.
(Double quotes specify the name of a column, single quotes are string literals).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):
Previously, Patrick-Eichhorn wrote…
This is due to the Tick Script-, more precisely the InfluxDB -Syntax.
(Double quotes specify the name of a column, single quotes are string literals).
All right, good to know 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This change is