Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix match expression documentation #939

Conversation

Patrick-Eichhorn
Copy link
Contributor

@Patrick-Eichhorn Patrick-Eichhorn commented Oct 19, 2020

This change is Reviewable

Copy link
Member

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Patrick-Eichhorn)


components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):

              {'Options are: level(), changed() and tag matching.'}
              <br />
              {'Example: (level() >= WARNING) AND ("host" == \'s001.example.com\')'}

My feeling says it should be the same quote sign, e.g., "host" == "s001.example.com", but I might be wrong.

Copy link
Contributor Author

@Patrick-Eichhorn Patrick-Eichhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Henning-Schulz)


components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):

Previously, Henning-Schulz (Henning Schulz) wrote…

My feeling says it should be the same quote sign, e.g., "host" == "s001.example.com", but I might be wrong.

This is due to the Tick Script-, more precisely the InfluxDB -Syntax.
(Double quotes specify the name of a column, single quotes are string literals).

Copy link
Member

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved


components/inspectit-ocelot-configurationserver-ui/src/components/views/alerting/topics/editor/HandlerEditor.js, line 33 at r1 (raw file):

Previously, Patrick-Eichhorn wrote…

This is due to the Tick Script-, more precisely the InfluxDB -Syntax.
(Double quotes specify the name of a column, single quotes are string literals).

All right, good to know 👍

Copy link
Member

@Henning-Schulz Henning-Schulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Patrick-Eichhorn Patrick-Eichhorn merged commit 65fbef3 into inspectIT:master Oct 21, 2020
@Patrick-Eichhorn Patrick-Eichhorn deleted the fix_match_expression_documentation branch October 21, 2020 07:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants