Add audio preview of uploaded files #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in both resources screen and call flow steps. Fixes #654
ggiraldez
approved these changes
Nov 3, 2016
| @@ -28,6 +28,12 @@ | |||
| %input{:type => 'file', 'data-bind' => 'fileupload: url, fileuploadAdd: add, fileuploadprogressall: showProgress'} | |||
| Replace | |||
| / /ko | |||
| / ko if: hasAudio() && (uploadStatus() == 'ok' || uploadStatus() == 'standBy') | |||
| %br | |||
| %audio{'controls' => true, "style" => "width: 450px", "preload" => "none"} | |||
There was a problem hiding this comment.
Do we care about compatibility with old browsers? What does this do if the browser doesn't support the <audio> element or the audio format?
There was a problem hiding this comment.
IE9+ supports audio tag. And the call flow designer currently does not work in IE8:
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in both resources screen and call flow steps.
Fixes #654