Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

22: Add configuration options for introducing dependabot #180

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

adigidh
Copy link
Contributor

@adigidh adigidh commented Sep 18, 2024

fixes #22

Enabling dependabot for the repository. The configuration aims at addressing Docker images, npm packages, and go modules.

Summary of changes:

  • Used Grouping: Dependabot will group certain dependencies with the keyword “group”.
  • For github-actions, I just used a single group, and used a wildcard pattern to achieve like an "everything group".
  • Limiting the security updates to the dependencies and ignore dev dependencies. Highlighted in dependency-type: "production"

@adigidh
Copy link
Contributor Author

adigidh commented Sep 18, 2024

Might need one of the maintainers to help me with enabling this on the repo settings:
https://docs.github.com/en/code-security/getting-started/dependabot-quickstart-guide#enabling-dependabot-for-your-repository

Other questions:

  • Do you want dependably PRs be opened at certain timeframe? Weekly/ monthly or at a certain time?
  • Would you be open to assigning specific reviewers for dependably pull requests?
  • Is it okay to create custom labels for the issues dependabot opens?

@vishnoianil vishnoianil requested review from a team, vishnoianil, juancappi, chungtan, Gregory-Pereira, aevo98765 and renrenstart and removed request for a team September 20, 2024 07:24
@vishnoianil
Copy link
Member

Might need one of the maintainers to help me with enabling this on the repo settings: https://docs.github.com/en/code-security/getting-started/dependabot-quickstart-guide#enabling-dependabot-for-your-repository

@adigidh This is done.

Other questions:

  • Do you want dependably PRs be opened at certain timeframe? Weekly/ monthly or at a certain time?

I think weekly would be a better option.

  • Would you be open to assigning specific reviewers for dependably pull requests?

We have instructlab/ui-maintainers group that has all the maintainers in it. I think it's good to add that group as a reviewer. If that doesn't workout, please add me and @nerdalert as a reviewer.

  • Is it okay to create custom labels for the issues dependabot opens?
    Absolutely!

Thanks for the PR @adigidh , Great work! Appreciate it.

@vishnoianil
Copy link
Member

@adigidh Can you please signoff your commit, so that it can pass the DCO job. Thanks!

Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good. Minor comments and requires DCO fixing.

labels:
- "npm dependencies"
- "frontend"
open-pull-requests-limit: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably remove this limit ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the limit as suggested. We can add it back in later incase we feel like dependabot is introducing a lot of noise with PRs per week 👍

- "go dependencies"
open-pull-requests-limit: 3
- package-ecosystem: "docker"
directory: "/server"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should point it to /deploy directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dockerfile is in the server directory, and we'll have to specify the root directory where dependabot should look for dockerfiles. The /deploy directory didn't have any dockerfiles.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense. We don't use the docker file in /server currently. Mainly we use the one present in the root directory -Containerfile and Containerfile.ps, so i think we should point it to /?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Appreciate the details, I just made the update.

schedule:
interval: "monthly"
labels:
- "docker dependencies"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline here.

Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
@adigidh
Copy link
Contributor Author

adigidh commented Sep 20, 2024

Thanks for taking a look @vishnoianil.

Summary of changes:

  • Added reviewers to the configuration: "instructlab/ui-maintainers" group
  • Removed pull requests limit.
  • Requisite updates for DCO fixes.

@vishnoianil
Copy link
Member

Thanks for taking a look @vishnoianil.

Summary of changes:

  • Added reviewers to the configuration: "instructlab/ui-maintainers" group
  • Removed pull requests limit.
  • Requisite updates for DCO fixes.

awesome, one minor comment and it's good to go.

Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
@adigidh adigidh requested a review from vishnoianil September 23, 2024 20:21
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 336dd9f into instructlab:main Sep 23, 2024
5 checks passed
@vishnoianil
Copy link
Member

@adigidh Thank you for your contribution!

@adigidh adigidh deleted the 22-dependabot branch September 26, 2024 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dependabot to the repo
2 participants