-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
22: Add configuration options for introducing dependabot #180
Conversation
Might need one of the maintainers to help me with enabling this on the repo settings: Other questions:
|
@adigidh This is done.
I think weekly would be a better option.
We have instructlab/ui-maintainers group that has all the maintainers in it. I think it's good to add that group as a reviewer. If that doesn't workout, please add me and @nerdalert as a reviewer.
Thanks for the PR @adigidh , Great work! Appreciate it. |
@adigidh Can you please signoff your commit, so that it can pass the DCO job. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall PR looks good. Minor comments and requires DCO fixing.
.github/dependabot.yml
Outdated
labels: | ||
- "npm dependencies" | ||
- "frontend" | ||
open-pull-requests-limit: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably remove this limit ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing the limit as suggested. We can add it back in later incase we feel like dependabot is introducing a lot of noise with PRs per week 👍
.github/dependabot.yml
Outdated
- "go dependencies" | ||
open-pull-requests-limit: 3 | ||
- package-ecosystem: "docker" | ||
directory: "/server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should point it to /deploy directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the dockerfile is in the server directory, and we'll have to specify the root directory where dependabot should look for dockerfiles. The /deploy
directory didn't have any dockerfiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. We don't use the docker file in /server currently. Mainly we use the one present in the root directory -Containerfile and Containerfile.ps, so i think we should point it to /
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know. Appreciate the details, I just made the update.
.github/dependabot.yml
Outdated
schedule: | ||
interval: "monthly" | ||
labels: | ||
- "docker dependencies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a newline here.
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
8364a1f
to
865bde0
Compare
Thanks for taking a look @vishnoianil. Summary of changes:
|
awesome, one minor comment and it's good to go. |
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@adigidh Thank you for your contribution! |
fixes #22
Enabling dependabot for the repository. The configuration aims at addressing Docker images, npm packages, and go modules.
Summary of changes:
github-actions
, I just used a single group, and used a wildcard pattern to achieve like an "everything group".dependency-type: "production"