-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
153: Attribute information improvements #193
153: Attribute information improvements #193
Conversation
7439130
to
e34c3ca
Compare
Signed-off-by: ediazgallego <ediazgallego93@gmail.com>
Signed-off-by: ediazgallego <ediazgallego93@gmail.com>
Are we going to implement the logic here to auto-populate the other attribution fields like suggested in the issue? The re-ordering of the input fields looks good so great job with this! |
Not very familiar how big or small the changes should be for each PR, but to me the auto-populate logic seems a different concern than fixing the formatting part, so maybe creating another issue that will focus on fixing that part could be a good idea, wdyt? |
Happy with this. I think the smaller increments we push to main the better. Lets make sure that all the important contextual information get populated into the new issue. Put a link to the new issue in here when created. Then we will get this pushed through. |
@aevo98765 here is the new issue created as a follow-up of the remaining work to complete the full logic of auto-populate behavior 195 |
@ediazgallego Tracking through different issue sounds good. Thanks for creating the issue. This PR looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the contribution! @ediazgallego
Why
Existing implementation: The existing form places the URL after the name requiring user to manually enter all fields
UX recommendations
What:
Reference
How to test:
Screenshots
Before
After