Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update login background images #283

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

andybraren
Copy link
Contributor

@andybraren andybraren commented Oct 18, 2024

The background image used in the login page has some slight misalignment and yellow artifacts around the edges, most noticeable in the top- and bottom-right corners. See below.

This PR replaces the PNG and SVG versions files with fixed versions.

Before

2024-10-18 17 27 03

After

InstructLab-Background-Image

@andybraren andybraren force-pushed the fix-login-background-image branch from f055be9 to cfb2a90 Compare October 18, 2024 22:32
@andybraren
Copy link
Contributor Author

andybraren commented Oct 18, 2024

Tweaked this a bit further to remove the hard corners, which will matter for an upcoming PR to adjust the resizing behavior of the background image on the login page.

@andybraren andybraren force-pushed the fix-login-background-image branch from cfb2a90 to 0ec9cd9 Compare October 18, 2024 22:38
@andybraren andybraren changed the title Fix login background images Update login background images Oct 18, 2024
Adjusts alignment, removes artifacts, and removes hard edges for responsive purposes.

Signed-off-by: Andy Braren <abraren@redhat.com>
@andybraren andybraren force-pushed the fix-login-background-image branch from 0ec9cd9 to 759cebb Compare October 18, 2024 23:28
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm!

@nerdalert nerdalert merged commit 6172719 into instructlab:main Oct 20, 2024
3 checks passed
@vishnoianil vishnoianil added the cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch. label Oct 21, 2024
@vishnoianil
Copy link
Member

@andybraren can you please cherry-pick this to release-1.0 branch as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants