Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Enable the UI to operate with a local git repo only #314

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

nerdalert
Copy link
Member

@nerdalert nerdalert commented Nov 3, 2024

  • This creates a local git repo and branch(es) for submissions. See the video for functionality.
  • This does not disrupt any existing functionality as it is only enabled with experimental mode turned on. Depends on Add a flag to allow for dynamic loading of experimental features #309 merging.
  • The git operations are server side renders as there is very little support for client side file system access outside of experimental support in chrome with showDirectoryPicker. Did not dig a great deal on this, just feels more sane to do it from the server side. The user will be running the server locally in this scenario or can run it as a service as desired as well.
local-ui-v1.mp4

TODO not necessarily on this PR:

  • Author info needs to use the email since there is no GitHub ID that can be discovered. Also how does that square with the IL v2 spec.
  • Dashboard needs to sort on date, not list the main branch and add more info/columns.
  • Add an empty state with get started links for local actions.
  • Knowledge file handling (definitely a separate PR).
  • Determine what we call local mode in general. local is meh.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
- Also redirect the submission success popup to the local dashboard

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@vishnoianil
Copy link
Member

LGTM

@vishnoianil vishnoianil merged commit 0a2ed73 into instructlab:main Nov 7, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants