Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove combining tags steps and restructure multiple tags #346

Merged

Conversation

Gregory-Pereira
Copy link
Collaborator

Previous workflow failed, see logs: https://github.com/instructlab/ui/actions/runs/11862220666/job/33061144701#step:13:213.

The issue here was that the extracted tag data from one of the "${{ steps.ghcr_ui_meta.outputs.tags }}" values resolves to something like quay.io/instructlab-ui/pathservice:main where as the combined tags got only the image tag, resolving to pr-334. This is why it would complain because it thinks the whole image ref was pr-334 and so it couldn't build. I have refactored my approach to the tagging which I think should work, and refactored for simplicity.

cc @vishnoianil @nerdalert

Signed-off-by: greg pereira <grpereir@redhat.com>
@vishnoianil vishnoianil merged commit 754f02f into instructlab:main Nov 17, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants