-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor image workflows to parallel matrix #363
Merged
vishnoianil
merged 1 commit into
instructlab:main
from
Gregory-Pereira:streamline-release-images-workflow
Nov 27, 2024
Merged
refactor image workflows to parallel matrix #363
vishnoianil
merged 1 commit into
instructlab:main
from
Gregory-Pereira:streamline-release-images-workflow
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going to move this as an upstream pr for testing purposes |
moved to: #364 |
|
95f7c3d
to
90c1236
Compare
90c1236
to
1b987b6
Compare
For store and key example see: https://github.com/orgs/community/discussions/26302#discussioncomment-3251298 |
1b987b6
to
5086bc7
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
5086bc7
to
0e2d36c
Compare
vishnoianil
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Dec 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, while does not speedup our workflows, makes it considerably less code, and easier to update. We should consider if we want something like this conceptually.