Move requirements into setup.py

[fralik]

• By moving requirements into setup.py file we make sure that necessary dependencies are installed automatically when user performs pip install mtscomp.

[oliche]

Agreed, the setup.py should install requirements !
But it's a good practice to keep the requirements file and read it from the setup as this:

with open('requirements.txt') as f:
    require = [x.strip() for x in f.readlines() if not x.startswith('git+')]
...
install_requires=require,

[fralik]

OK, can do this. Although, I do not see a real value of a separate requirements file. It is normally used to recreate a development/production environment as a whole, i.e. it would contain pinned version of all libraries (direct dependencies and their subdependencies) installed in an environment. There are tools, like pip-tools, that are able to generate such requirements file from various sources. But since mtscomp may be seen as a library rather than a deployable app, it doesn't make much sense to freeze the environment in a file.

From the code example you provided, why would you want to exclude git+ requirements? Setuptools is able to install those as far as I know.

[fralik]

@oliche , implemented your suggestion about using requirements file.