Respect KUBECACHEDIR environment variable
#975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check for the existence of a (non-empty) `KUBECACHEDIR` environment variable that will be used to construct the cache directory path if present.
|
As the developer of KUBECACHEDIR feature in k8s, I think that would be a useful feature in this plugin. |
int128
approved these changes
Dec 16, 2023
|
Thank you for the great contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check for the existence of a (non-empty)
KUBECACHEDIRenvironment variable that will be used to construct the cache directory path if present.Tested locally with variable set/unset and directory empty/non-empty, works fine.
Programmatic tests aren't there yet, I'd love a pointer on how you'd want to harness testing depending on an environment variable, since I only see usage of tests for e.g.
$KUBECONFIGinacceptance_test/integration_test