You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In the workflow I am building, which takes the form a package, I want to extend the esm_datastore class with some quite specific functionalities. Mostly things that don't really make sense in intake_esm directly. However, when subclassing esm_datastore, a call to search returns a esm_datastore object because the class is explicitly initialized.
Describe alternatives you've considered
A complicated override of search on my subclass. Since the introduction of the derived variable registry, this has been complicated and it's not only a matter of reconstructing a new object with the new df.
The text was updated successfully, but these errors were encountered:
A complicated override of search on my subclass. Since the introduction of the derived variable registry, this has been complicated and it's not only a matter of reconstructing a new object with the new df.
Sorry to hear about this complication introduced by the DerivedVariable registry functionality... The DerivedVariable registry functionality is a little finicky/fragile for the time being. So, I think your proposed change is reasonable and would welcome a PR.
I really like the DerivedVariable feature, so I didn't mean this as a critic! The complexity it introduces simply justifies the suggested change. PR coming real soon.
Is your feature request related to a problem? Please describe.
In the workflow I am building, which takes the form a package, I want to extend the
esm_datastore
class with some quite specific functionalities. Mostly things that don't really make sense inintake_esm
directly. However, when subclassingesm_datastore
, a call tosearch
returns aesm_datastore
object because the class is explicitly initialized.Describe the solution you'd like
Replacing:
intake-esm/intake_esm/core.py
Line 347 in e24e39c
with:
Describe alternatives you've considered
A complicated override of
search
on my subclass. Since the introduction of the derived variable registry, this has been complicated and it's not only a matter of reconstructing a new object with the newdf
.The text was updated successfully, but these errors were encountered: