Search returns same class as self - allowing subclassing #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersy005
added
the
enhancement
andersy005
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Thank you for this contribution, @aulemahal! The CI failures are unrelated to this PR.
Should I add a unit test for this? It's not something I ever tested in other projects.
Feel free to add one if it doesn't require too much work. Otherwise, I'd be happy to merge this as is.
|
@aulemahal, let me know if you are planning to add the unit test otherwise I'm going to merge this later today. |
|
Thank you, @aulemahal! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
esm_datastore.searchthe result is instantiated from the same class asself, allowing subclassing.Related issue number
esm_datastore#415Checklist
Should I add a unit test for this? It's not something I ever tested in other projects. I mean
intake_esmdoes not have subclasses ofesm_datastorethus testing this feature is somewhat out of scope? I can quickly add a basic one if you prefer.