Support iterable columns with require_all_on
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersy005
reviewed
Jan 24, 2022
There was a problem hiding this comment.
Sweet! Thank you for this addition, @aulemahal! I left a few suggestions. Let me know what you think.
andersy005
added
the
enhancement
|
Thank you, @aulemahal! This looks great... |
andersy005
changed the title
require_all_on
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I added a small function to "unpack" the iterable columns into multiple lines, this way the "index" used to check for the "require_all_on" condition is populated with the real elements to compare, not the iterables of elements.
Related issue number
Fixes #434
Checklist