Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Subset derived variable registry only with used derived variables #446

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

aulemahal
Copy link
Contributor

Change Summary

When searching for variables, the subset of the derived variable registry is constructed from the dependent variables that returned results when their query was searched.

This mainly changes two things:

  • If a derived variable has a dependent that also exists as a derived variable in the DVR, that second dv is nonetheless not included in the subset. Fixing Don't include dependents when filtering the derived variable registry #445.
  • If a requested variable corresponds to a derived variable but none of the dependents were found in the catalog, that derived variable is not included in the subset. I don't think this is a breaking change. That behaviour was not causing problems on my side, but I do think it's a bit cleaner this way?

Related issue number

Fixes #445.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aulemahal, Thank you for a thorough report in #445 and for your work on this! I appreciate it!

This looks great to me 👍🏽

@andersy005 andersy005 added enhancement Issues that are found to be a reasonable candidate feature additions bug-fix labels Feb 10, 2022
@andersy005 andersy005 changed the title Subset DVR only with used DVs - add tests Subset derived variable registry only with used derived variables Feb 10, 2022
@andersy005 andersy005 merged commit 2f82a0c into intake:main Feb 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug-fix enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't include dependents when filtering the derived variable registry
2 participants