Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DOC: GEFS example #40

Merged
merged 3 commits into from
Jun 11, 2021
Merged

DOC: GEFS example #40

merged 3 commits into from
Jun 11, 2021

Conversation

raybellwaves
Copy link
Contributor

Closes #37

@andersy005
Copy link
Member

andersy005 commented Jun 9, 2021

Thank you for putting this together, @raybellwaves! To fix the linting issue, could you enable pre-commit locally with pre-commit install and then run pre-commit run --all-files. (pre-commit should be installed if you set up the local dev environment).

Also, could we put this example under its own sub-heading. Currently, it's under the caching heading and it would be better to have a separate heading for it. @aaronspring, any thoughts on what this new sub-heading could be?

@aaronspring
Copy link
Collaborator

Advanced example with cfgrib?

@aaronspring
Copy link
Collaborator

I think Anderson meant a ## subheading.

Multi-file concat_kwargs cfgrib

under ## caching

@aaronspring
Copy link
Collaborator

I now realise that my example wasn’t that super good. Only one dimension concationated. Wouldn’t actually require concat_kwargs IMO.

path = "NCEP gens-a Grid 3 Member-Forecast -3 for 2020-08-31 00:00*" (haven’t tried)

could maybe concat 21 number and a few steps.

@raybellwaves
Copy link
Contributor Author

I now realise that my example wasn’t that super good. Only one dimension concationated. Wouldn’t actually require concat_kwargs IMO.

path = "NCEP gens-a Grid 3 Member-Forecast -3 for 2020-08-31 00:00*" (haven’t tried)

could maybe concat 21 number and a few steps.

multi-dim concat is probably out of the scope here.

Been a while since I looked at that (https://stackoverflow.com/questions/47545138/python-xarray-open-mfdataset-concat-along-two-dimensions ; https://stackoverflow.com/questions/51487206/combining-spatial-netcdf-files-using-xarray-python/59377471#59377471)

@andersy005 this good to go?

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @raybellwaves! The CI failures are unrelated. Merging this shortly

@andersy005 andersy005 merged commit cc3758f into intake:main Jun 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Aaron's tweet example to docs
3 participants