Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MGDAPI-5078 - feat: allow applying redis node size changes immediately #625

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Jan 23, 2023

Overview

  • feat: allow applying immediately for redis node size changes
  • release: 0.44.0

Jira: https://issues.redhat.com/browse/MGDAPI-5078

Verification

  • Verified node size changes are apply immediately when applyImediately and maintenanceWindow is set to true on spec with @austincunningham

image
image
image

Checklist

  • This PR includes a change to an instance type, I have used script hack/<provider>/supported_types.sh and attached the result below

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #625 (5e08da4) into master (caafba3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   68.75%   68.77%   +0.01%     
==========================================
  Files          38       38              
  Lines        5115     5118       +3     
==========================================
+ Hits         3517     3520       +3     
  Misses       1238     1238              
  Partials      360      360              
Impacted Files Coverage Δ
pkg/client/util.go 91.89% <100.00%> (+0.22%) ⬆️
pkg/providers/aws/provider_redis.go 61.64% <100.00%> (+0.05%) ⬆️

@KevFan KevFan changed the title [WIP] MGDAPI-5078 - feat: allow applying redis node size changes immediately MGDAPI-5078 - feat: allow applying redis node size changes immediately Jan 23, 2023
@austincunningham
Copy link
Member

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austincunningham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3b706d4 into integr8ly:master Jan 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants