Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MGDAPI-6317 change the provider openshift redis to version 7 #801

Merged
merged 1 commit into from
May 22, 2024

Conversation

austincunningham
Copy link
Member

Overview

Jira: MGDAPI-6317

Verification

  • Clone this branch
  • Run make cluster/prepare
  • Run make cluster/seed/redis
  • Run make run
  • wait for the redis pod to be ready and check the version
oc logs $(oc get po | awk '{print $1}'| sed -n '2 p') 
1:C 21 May 2024 14:26:31.604 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 21 May 2024 14:26:31.604 # Redis version=7.0.12, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 21 May 2024 14:26:31.604 # Configuration loaded
1:M 21 May 2024 14:26:31.604 * monotonic clock: POSIX clock_gettime
1:M 21 May 2024 14:26:31.605 * Running mode=standalone, port=6379.
1:M 21 May 2024 14:26:31.605 # Server initialized
1:M 21 May 2024 14:26:31.605 * Ready to accept connections

Checklist

  • This PR includes a change to an instance type, I have used script hack/<provider>/supported_types.sh and attached the result below

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (978b82e) to head (29f1e7a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          54       54           
  Lines        7060     7060           
=======================================
  Hits         5120     5120           
  Misses       1545     1545           
  Partials      395      395           
Files Coverage Δ
pkg/providers/openshift/provider_redis.go 80.39% <100.00%> (ø)

Copy link
Contributor

@carlkyrillos carlkyrillos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changed file and confirmed Redis was created provisioned properly with the correct version.

[ckyrillo@ckyrillo-thinkpadp1gen3 cloud-resource-operator (MGDAPI-6317)]$ oc logs $(oc get po | awk '{print $1}'| sed -n '2 p') 
1:C 22 May 2024 19:31:38.932 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
1:C 22 May 2024 19:31:38.932 # Redis version=7.0.12, bits=64, commit=00000000, modified=0, pid=1, just started
1:C 22 May 2024 19:31:38.932 # Configuration loaded
1:M 22 May 2024 19:31:38.933 * monotonic clock: POSIX clock_gettime
1:M 22 May 2024 19:31:38.933 * Running mode=standalone, port=6379.
1:M 22 May 2024 19:31:38.933 # Server initialized
1:M 22 May 2024 19:31:38.933 * Ready to accept connections

/lgtm

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlkyrillos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9b5228e into integr8ly:master May 22, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants