Fix incorrect type resolution around array property accesses #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Dec 6, 2024
delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolver.java
Outdated
Show resolved
Hide resolved
Cirras
force-pushed
the
array_property_type_resolution
branch
from
14e88d5 to
d29ce7e
Compare
#313 introduced a regression in type resolution for plain array properties. We started erroneously calling `addResolvedDeclaration()` before resolving array properties, where before we would exit immediately and return to argument disambiguation on the array accessor. The effect was a subtle breakage of the type resolution around array properties. Take, for example, the expression `Foo.Bar[0]`, where `Bar` is an array property returning `string`. The old behavior would yield type `string`, while the new behavior would yield type `Char` due to the premature `addResolvedDeclaration()` call updating the `currentType` to `string` before the array accessor was processed.
Cirras
force-pushed
the
array_property_type_resolution
branch
from
d29ce7e to
392c692
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#313 introduced a regression in type resolution for plain array properties.
We started erroneously calling
addResolvedDeclaration()before resolving array properties, where before we would exit immediately and return to argument disambiguation on the array accessor.The effect was a subtle breakage of the type resolution around array properties. Take, for example, the expression
Foo.Bar[0], whereBaris an array property returningstring. The old behavior would yield typestring, while the new behavior would yield typeChardue to the prematureaddResolvedDeclaration()call updating thecurrentTypetostringbefore the array accessor was processed.