add delete branch on merge option on datasource github repository #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alileza feel free to promote this from draft when you're comfortable! |
|
Would you mind adding checks for these new attributes to |
nickfloyd
approved these changes
Aug 6, 2024
nickfloyd
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Hey thanks for the changes here! ❤️ We'll go ahead and merge / ship this but if you get the chance would you mind adding your fields to the documentation as well?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change?
Supporting a couple more fields from repository api
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!