Program scope hostpipe support #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zibaiwan
commented
Apr 4, 2023
•
zibaiwan
commented
- Support program scope hostpipe, CSR pipe and non-CSR pipe.
- Register program scoped hostpipes during program creation.
- Create new command op and device op for the hostpipe read and write
- Unit test is only for the auto-discovery string. Other unit tests will be added through other PR.
- Most of the Klocwork issues are the existing issues but listed as the new issues due to I modified the source code for the test, but I will attempt to fix all of them.
- More error checking needs to be done. Will add through a new PR.
|
@sophimao , while I am still working on the Klocwork fixes, please take a look at the change. Thanks! |
sophimao
previously approved these changes
Apr 4, 2023
1. Support program scope hostpipe, CSR pipe and non-CSR pipe. 2. Register program scoped hostpipes during program creation. 3. Create new command op and device op for the hostpipe read and write. 4. Create unit tests for the new autodiscovery string entry 5. Fix Klocwork issues in the deivce op unit test as they are flagged as new failures (they are not) due to my change in the device op
zibaiwan
force-pushed
the
native-host-pipe
branch
from
6d303cf
to
704f98a
Compare
|
@sophimao , thanks for your review. I have addressed your comments, squashed the commits. Please take a look when you have a chance! |
sophimao
approved these changes
Apr 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.