Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Correct CSR pipe behaviour when StallFree is used #340

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Correct CSR pipe behaviour when StallFree is used #340

merged 1 commit into from
Mar 4, 2024

Conversation

zibaiwan
Copy link
Contributor

@zibaiwan zibaiwan commented Jan 17, 2024 •
edited
Loading

  1. Parse the new IsStallFree info from compiler.
  2. Correct the CSR pipe write&read behavior based on the property

Basic test passed with the design provided in the Case. More scenarios are being tested.

sophimao
sophimao reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai, looks good to me mostly except one question below:

src/acl_hostch.cpp Outdated Show resolved Hide resolved
src/acl_hostch.cpp Show resolved Hide resolved
sophimao
sophimao approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@sophimao sophimao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zibai!

@zibaiwan zibaiwan merged commit 0f1ec3a into intel:main Mar 4, 2024
23 checks passed
@zibaiwan zibaiwan deleted the stall-free branch March 4, 2024 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sophimao sophimao sophimao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zibaiwan @sophimao