Add cl_intel_unified_shared_memory to supported extensions #94
Conversation
The SYCL runtime uses but currently does not check for this extension. From a cursory glance all new API functions are implemented. https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_unified_shared_memory.html
There was a problem hiding this comment.
LGTM
(although technically memadvise is not implemented yet)
fpga-runtime-for-opencl/src/acl_usm.cpp
Line 999 in 49a70bb
|
Rerunning the Windows build workflows after #96 was merged did not update the base branch commit into which the pull-request branch is merged, which means that the workflows still fail. I have not pushed a rebased PR since that would dismiss reviewer approval. Instead I will be trying the repository setting Always suggest updating pull request branches to see whether it retains reviewer approval. |
|
The repository setting Always suggest updating pull request branches indeed enabled the Update branch button, which merges the up-to-date main branch into the pull request branch. This is not quite the same as manual rebasing, but it retains reviewer approval. Merge with rebase then removes the merge commit again. |
The SYCL runtime uses but currently does not check for this extension.
From a cursory glance all new API functions are implemented.
https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_unified_shared_memory.html