move pkg/topology to proper upstream #1379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
- Coverage 50.77% 50.38% -0.39%
==========================================
Files 44 44
Lines 5022 4896 -126
==========================================
- Hits 2550 2467 -83
+ Misses 2326 2289 -37
+ Partials 146 140 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mythi
force-pushed
the
PR-2023-017
branch
2 times, most recently
from
f9efadc to
104161b
Compare
|
keeping this in draft until we have a release for |
A proper upstream for the sysfs topology parsing is containers/nri-plugins se we can drop the duplicated code. At the same time, we no longer need to carry scripts/ttar and the sys.ttar unpacking for the tests because the remaining testdata becomes easier to maintain (the original testdata contained PCI BDF paths that trigged issues). Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
|
unlikely to happen. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1366