Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changed nmake to build against MSVCRT (/MD, /MDd) #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gh-andre
Copy link

@gh-andre gh-andre commented Feb 9, 2025

  • When the runtime type option is omitted, VC++ builds object files with a LIBCMT directive, which is a thread-safe statically linked runtime library.
  • This change adds explicit release and debug dynamic CRT options into build configurations.

* When the runtime type option is omitted, VC++ builds object
  files with a `LIBCMT` directive, which is a thread-safe statically
  linked runtime library.
* This change adds explicit release and debug dynamic CRT
  options into build configurations.

Signed-off-by: gh-andre <gh-andre@users.noreply.github.com>
@gh-andre
Copy link
Author

gh-andre commented Feb 9, 2025

Just a quick note here - it probably makes sense to mention this change in release notes, as it may affect those who customized their projects to either patch the source to use the dynamic CRT, like I did for mine, or to structure their projects around a static CRT, which means that they will not share memory allocation, global initialization, like threading/locking, etc., with those same resources in isa-l_crypto.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant