This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Adds regression test for ensuring SYCL_EXTERNAL is ignored by kernel bundles #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kernel bundles These changes add a regression test to ensure that exported device functions do not appear as kernels in kernel bundles. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
requested review from
bader,
romanovvlad and
vladimirlaz
as code owners
romanovvlad
reviewed
Sep 29, 2021
| @@ -0,0 +1,45 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
| // RUN: %HOST_RUN_PLACEHOLDER %t.out | |||
There was a problem hiding this comment.
Does it make sense to run on the host device if the test skips execution on such a device(line 22)?
There was a problem hiding this comment.
Good point. I don't think so, so I have removed it.
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
dm-vodopyanov
approved these changes
Sep 30, 2021
vladimirlaz
approved these changes
Oct 5, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…kernel bundles (intel/llvm-test-suite#486) These changes add a regression test to ensure that exported device functions do not appear as kernels in kernel bundles. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a regression test to ensure that exported device functions do not appear as kernels in kernel bundles.
This will pass when intel/llvm#4660 is merged.