Skip to content

DPC++ Feature Testing #1825

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ax3l opened this issue Jun 5, 2020 · 2 comments
Closed

DPC++ Feature Testing #1825

ax3l opened this issue Jun 5, 2020 · 2 comments

Comments

@ax3l
Copy link

ax3l commented Jun 5, 2020

Hi,

it would be great for us if DPC++ and general SYCL extension features can be detected via macro and/or other feature tests in codes.

Currently, out of the list in here https://spec.oneapi.com/versions/latest/elements/dpcpp/source/index.html it seems that only SYCL_INTEL_unnamed_kernel_lambda has a feature test macro (__SYCL_INTEL_UNNAMED_LAMBDA__), but I might be missing something.

This would help us downstream developers to test proposed SYCL features with simple fallback paths for various SYCL compilers.

Refs.:

@bader
Copy link
Contributor

bader commented Jun 6, 2020

@ax3l, thanks for the feedback.
We discussed this topic here: #806 and @AlexeySachkov prepared a PR with the detailed proposal: #1793.
Please, let us know if it doesn't fit your needs.

@ax3l
Copy link
Author

ax3l commented Jun 6, 2020

Thanks a lot @bader, I will close this as duplicate and contributed additional thoughts in both the issue and PR :)

@ax3l ax3l closed this as completed Jun 6, 2020
KornevNikita pushed a commit to KornevNikita/llvm that referenced this issue Feb 2, 2023
Update for llvm-project commit 89427bb ("[NFC] Deprecate
DataLayout::getPrefTypeAlignment", 2023-01-24).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@adb62c1
KornevNikita pushed a commit to KornevNikita/llvm that referenced this issue Feb 20, 2023
Update for llvm-project commit 89427bb ("[NFC] Deprecate
DataLayout::getPrefTypeAlignment", 2023-01-24).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@adb62c1
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants