Skip to content

[SYCL][FE] Add an attribute to annotate special sycl types #2041

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Fznamznon opened this issue Jul 6, 2020 · 1 comment
Closed

[SYCL][FE] Add an attribute to annotate special sycl types #2041

Fznamznon opened this issue Jul 6, 2020 · 1 comment
Assignees
@Fznamznon
Labels
upstream This change is related to upstreaming SYCL support to llorg.

Comments

@Fznamznon
Copy link
Contributor

This is follow up task to address #1877 (comment) and probably https://reviews.llvm.org/D71016#inline-644645 .
To fix this we need to add an attribute to annotate SYCL types like accessor, sampler, image. It's much more reliable approach than declaration name, which introduces hard-coded dependency on exact symbol name in the runtime library.
@Fznamznon Fznamznon self-assigned this Jul 6, 2020
This was referenced Jul 6, 2020
Merged
Closed
@bader bader added the upstream This change is related to upstreaming SYCL support to llorg. label Jan 25, 2021
@Fznamznon
Copy link
Contributor Author

I think it was implemented by #3892 and https://reviews.llvm.org/D114483

jsji pushed a commit that referenced this issue Jun 8, 2023
@vmaksimo @sys-ce-bb
Update DebugInfo/X86/split-dwarf-omit-empty.ll after commit e731a26 (#…
d4ef724 
…2041)

llvm/llvm-project@e731a26

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@c55505a
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Fznamznon Fznamznon

Labels
upstream This change is related to upstreaming SYCL support to llorg.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP][SYCL] Implement sycl_special_class attribute Fznamznon/llvm
2 participants
@bader @Fznamznon