Skip to content

[XPTI] Include path not setup correctly when building pi-trace #4137

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Naghasan opened this issue Jul 19, 2021 · 4 comments
Closed

[XPTI] Include path not setup correctly when building pi-trace #4137

Naghasan opened this issue Jul 19, 2021 · 4 comments
Assignees
@alexbatashev
Labels
bug Something isn't working

Comments

@Naghasan
Copy link
Contributor

Describe the bug

When building pi-trace with tip sycl, the include path to xpti seems to not be configured properly.

I end up with a

llvm/sycl/tools/pi-trace/pi_trace.cpp:13:10: fatal error: xpti_trace_framework.h: No such file or directory
   13 | #include "xpti_trace_framework.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I tried a fresh build and configured using the configure script in the buildbot folder (python3 buildbot/configure.py -s . -o ../build -t Release --cuda), but after this I end up with the path to opencl headers not being found:

llvm/sycl/include/CL/sycl/detail/cl.h:17:10: fatal error: CL/cl.h: No such file or directory
   17 | #include <CL/cl.h>

(I rely on the headers pulled by the project)

If I remove the add_subdirectory(pi-trace) from sycl/tools everything builds fine.

Environment (please complete the following information):

  • OS: Ubuntu 20.04
  • DPC++ version: ea4b8a9
@Naghasan Naghasan added the bug Something isn't working label Jul 19, 2021
@bader
Copy link
Contributor

bader commented Jul 19, 2021

This looks like a regression introduced by e239fdf.
@alexbatashev, could you fix this ASAP, please?

@danchitnis
Copy link

Further error log info here:
#4050 (reply in thread)

@rolandschulz
Copy link
Contributor

I can confirm that reverting e239fdf fixes the problem. Why don't we revert that commit until the issue is resolved?

@bader bader mentioned this issue Jul 19, 2021
Merged
@bader
Copy link
Contributor

bader commented Jul 19, 2021

Done by #4144.

@bader bader closed this as completed Jul 19, 2021
@alexbatashev alexbatashev mentioned this issue Jul 20, 2021
Merged
bader pushed a commit that referenced this issue Jul 22, 2021
[SYCL][XPTI] Enable PI calls notifications with arguments (#4148)
66770f0 
This patch re-lands #3973 with fixes to #4137

----

This PR adds capability to capture PI calls' arguments and pass this data to XPTI subscribers. The sample pi-trace library demonstrates how one can parse this data on the subscriber side. An example usage of this utility would be:
```bash
XPTI_TRACE_ENABLE=1 XPTI_FRAMEWORK_DISPATCHER=lib/libxptifw.so XPTI_SUBSCRIBERS=lib/libpi_trace.so ./my_app
```
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alexbatashev alexbatashev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rolandschulz @bader @alexbatashev @Naghasan @danchitnis