[SYCL][FPGA] Enable uses_global_work_offset attribute #1010
Conversation
vmaksimo
force-pushed
the
global_work_offset
branch
from
1f1844a to
52b1d5b
Compare
Signed-off-by: Viktoria Maksimova <viktoria.maksimova@intel.com>
Signed-off-by: Viktoria Maksimova <viktoria.maksimova@intel.com>
vmaksimo
force-pushed
the
global_work_offset
branch
from
52b1d5b to
535c0cd
Compare
Signed-off-by: Viktoria Maksimova <viktoria.maksimova@intel.com>
| /*StrictlyUnsigned=*/true)) | ||
| return; | ||
| if (Enabled > 1) | ||
| S.Diag(Attr.getLoc(), diag::warn_boolean_attribute_argument_is_not_valid) |
There was a problem hiding this comment.
Do you need to reset Enabled to 1 if the warning is generated, or will that be handled in the generation?
There was a problem hiding this comment.
No need, as it is handled in code generation - CodeGenFunction.cpp:674
|
Please, add justification for adjusted-attributes diagnostics group to the PR description or code comments. The reason for adding a new group is not clear. |
updated PR description |
Why do we need put the attribute to any group? |
There is a requirement that all new warnings should be associated with -W flag (see |
uses_global_work_offsetattribute applies to a device function/lambda function or function call operator. Valid values are 0 and 1.If value >1 is specified as an argument, we warn user that it will be adjusted to 1. As attribute is not ignored in this case and it does not match any existing diagnostic group, the new
AdjustedAttributesgroup was added.