-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Driver] Enable SPV_INTEL_memory_access_aliasing extension #14992
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
@maarquitos14, will there be additional changes done to the |
Tbh, I just adapted #4025 to the current codebase. What additional changes do we need to add this extension for the new offloading model? |
Perform a similar addition to
|
Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - OK for driver. Is there some test for the extensions for clang-linker-wrapper?
I checked, but didn't find any. Glad to update it if I missed it. |
@maksimsab, @asudarsa, do you know? |
It looks like we are missing such a test. |
@mdtoguchi @AlexeySachkov should I add it here or should that be addressed in a different PR? |
@mdtoguchi @AlexeySachkov ping |
Fine by me to have it in a separate PR. Especially considering that longer term |
@intel/llvm-gatekeepers I think this is ready to merge :) |
@maarquitos14 I'm pretty sure you're already working on this but this broke all invokesimd tests (~55 tests) on dev igc arc, so I'm going to revert this, discussed with Jinsong. |
No description provided.