-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Implement work group memory extension #15178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This reverts commit 3b10242.
@intel/dpcpp-cfe-reviewers ping for review of the frontend changes and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add FE tests for FE changes. Since you're adding a new type of argument with some special handling in the FE, I would add an AST test ensuring the expected arguments are generated and a CodeGen test for the change in integration header.
My bad. I did not notice the test you added. No further changes are necessary |
@intel/llvm-gatekeepers ping for merge. |
Implement work group memory extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_memory.asciidoc
Two notes:
local_accessor