[UR][CUDA] Cleanup UMF pools creation code #18361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was roughly duplicated between the context and the platform, and could also be cleaned up and refactored to be clearer and not require as many helper functions and macros. It is going to create more "MemoryProviderParams" during platform initialization. But that cost of that is likely pretty small and not on the hot path, so it seems like a fair tradeoff for cleaner code.
frasercrmck
approved these changes
May 12, 2025
|
@intel/llvm-gatekeepers this is ready to merge, failures are unrelated (on Arc, this patch only touches CUDA), and tracked here: #18416 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was roughly duplicated between the context and the platform, and could also be cleaned up and refactored to be clearer and not require as many helper functions and macros.
It is going to create more "MemoryProviderParams" during platform initialization. But that cost of that is likely pretty small and not on the hot path, so it seems like a fair tradeoff for cleaner code.