[SYCL] Fix checkValueRange #18439
Merged
[SYCL] Fix checkValueRange #18439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code previously cast to unsigned, assuming that checking the lower 32 bits would be sufficient for the overflow calculation. This is not true, because casting a size_t to unsigned could result in a very small number, e.g. "std::numeric_limits<unsigned>::max() + 1" casts to 0. Signed-off-by: John Pennycook <john.pennycook@intel.com>
|
Failing tests are in #18416. |
aelovikov-intel
approved these changes
May 13, 2025
|
@intel/llvm-gatekeepers - This can be merged. See above comment regarding failed Arc tests. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously cast to unsigned, assuming that checking the lower 32 bits would be sufficient for the overflow calculation.
This is not true, because casting a
size_ttounsignedcould result in a very small number, e.g.std::numeric_limits<unsigned>::max() + 1casts to 0.