Skip to content

[UR][L0] Refactor IL code handling allowing future extension #18441

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

Maetveis
Copy link
Contributor

Refactor the code to make it easier to add support for different IL formats (besides SPIR-V) in the future.
The only functional change is that SPIR-V binaries with invalid magic number are now rejected by returning UR_RESULT_ERROR_INVALID_BINARY from urProgramCreateWithIL.

Refactor the code to make it easier to add support for different
IL formats (besides SPIR-V) in the future.
The only functional change is that SPIR-V binaries with invalid magic
number are now rejected by returning UR_RESULT_ERROR_INVALID_BINARY
from urProgramCreateWithIL.
@Maetveis Maetveis requested a review from a team as a code owner May 13, 2025 12:28
@Maetveis Maetveis temporarily deployed to WindowsCILock May 13, 2025 12:28 — with GitHub Actions Inactive
@Maetveis Maetveis temporarily deployed to WindowsCILock May 13, 2025 12:50 — with GitHub Actions Inactive
@Maetveis Maetveis temporarily deployed to WindowsCILock May 13, 2025 12:50 — with GitHub Actions Inactive
@Maetveis Maetveis temporarily deployed to WindowsCILock May 14, 2025 07:20 — with GitHub Actions Inactive
@Maetveis
Copy link
Contributor Author

I believe the CI failure (https://github.com/intel/llvm/actions/runs/14996606351/job/42133884358 ) is unrelated: #18416

@Maetveis Maetveis requested a review from kbenzie May 14, 2025 07:27
@Maetveis Maetveis temporarily deployed to WindowsCILock May 14, 2025 07:40 — with GitHub Actions Inactive
@Maetveis Maetveis temporarily deployed to WindowsCILock May 14, 2025 07:40 — with GitHub Actions Inactive
@Maetveis
Copy link
Contributor Author

I don't believe the CI failure is related:

[ RUN      ] urCommandBufferAppendMemBufferWriteRectTestWithParam.Success/Intel_R__oneAPI_Unified_Runtime_over_Level_Zero_V2__Intel_R__Data_Center_GPU_Max_1100_ID0ID______________________write_3D_with_offsets
Segmentation fault from GPU at 0x8057ffc01000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 0 (PTE), access: 0 (Read), banned: 1, aborting.
Segmentation fault from GPU at 0x8057ffc01000, ctx_id: 1 (CCS) type: 0 (NotPresent), level: 0 (PTE), access: 0 (Read), banned: 1, aborting.
Abort was called at 276 line in file:
../../neo/shared/source/os_interface/linux/drm_neo.cpp

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant