Skip to content

[SYCL][NFC] Pass adapter by reference in backend[_impl] #19187

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[SYCL][NFC] Pass adapter by reference in backend[_impl] #19187

merged 1 commit into from
Jul 1, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jun 27, 2025 •
edited
Loading

It's a part of larger refactoring effort to pass adapter via reference instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184

@uditagarwal97 uditagarwal97 self-assigned this Jun 27, 2025
@uditagarwal97 uditagarwal97 force-pushed the private/udit/adapter_refac2 branch from 4c31021 to 0ee6f51 Compare June 27, 2025 14:35
@uditagarwal97 uditagarwal97 marked this pull request as ready for review June 27, 2025 14:37
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner June 27, 2025 14:37
@uditagarwal97 uditagarwal97 force-pushed the private/udit/adapter_refac2 branch from 0ee6f51 to 0ed0037 Compare June 27, 2025 14:46
@uditagarwal97 uditagarwal97 mentioned this pull request Jun 27, 2025
Merged
maarquitos14
maarquitos14 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@uditagarwal97
Copy link
Contributor Author

Failure in Windows BMG:

********************
Failed Tests (3):
  SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
  SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
  SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

********************
Unexpectedly Passed Tests (5):
  SYCL :: bindless_images/array/fetch_handle_carray2d.cpp
  SYCL :: bindless_images/read_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_2D_O0.cpp
  SYCL :: bindless_images/sampling_1D_O0.cpp

Adapter tests were marked XFAIL in #19242 and Bindless images tests were fixed in #19215. All of these test failures are unrelated to this PR. Merging.

@uditagarwal97 uditagarwal97 merged commit b747578 into sycl Jul 1, 2025
40 of 46 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/adapter_refac2 branch July 1, 2025 16:09
uditagarwal97 added a commit that referenced this pull request Jul 3, 2025
@uditagarwal97
[SYCL][NFC] Pass adapter by ref in ur::getAdapter and event:getAdapter (
49405f5 
#19202)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
@uditagarwal97 uditagarwal97 mentioned this pull request Jul 4, 2025
Merged
uditagarwal97 added a commit that referenced this pull request Jul 4, 2025
@uditagarwal97
[SYCL][NFC] Make queue::getAdapter() return adapter ref instead of ptr (
b707123 
#19299)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
This was referenced Jul 4, 2025
Merged
Merged
Merged
Merged
uditagarwal97 added a commit that referenced this pull request Jul 7, 2025
@uditagarwal97
[SYCL][NFC] Make sycl_mem_obj::getAdapter() return by reference (#1…
f40967c 
…9312)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
#19299
uditagarwal97 added a commit that referenced this pull request Jul 8, 2025
@uditagarwal97
[SYCL][NFC] Make kernel_impl::getAdapter() return by reference (#19313
3f0530c 
)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
#19299
#19312
uditagarwal97 added a commit that referenced this pull request Jul 9, 2025
@uditagarwal97
[SYCL][NFC] Make context_impl::getAdapter() and `platform_impl::get…
026d2b3 
…Adapter()` return by reference (#19314)

It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
#19299
#19312
#19313
uditagarwal97 added a commit that referenced this pull request Jul 10, 2025
@uditagarwal97
[SYCL][NFC] Remove AdapterPtr from SYCL RT (#19315)
7187eea 
It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
#19187
#19202
#19299
#19312
#19313
#19314
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uditagarwal97 @maarquitos14